-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(twap): add missing tooltips #2843
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
limitPriceTooltip: ( | ||
<> | ||
If CoW Swap cannot get this price or better after fees and slippage are taken into account, your TWAP | ||
will not execute. CoW Swap will <strong>always</strong> improve on this price if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MindyCoW maybe this one can be a bit more positive? in the other part we were taking about price protection, so maybe we should mention sth like "CoW Swap will protect your order from executing at an unfavorable price"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with #2849 issue :)
Summary
Add missing tooltips
On TWAP review modal fields
On order receipt modal (Safe fields)
To Test